-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Fix style inconsistency #29199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Dec 16, 2024
CI Results: |
Build Results: |
website/content/docs/platform/k8s/vso/secret-transformation.mdx
Outdated
Show resolved
Hide resolved
jonathanfrappier
previously approved these changes
Dec 16, 2024
Co-authored-by: Jonathan Frappier <[email protected]>
jonathanfrappier
previously approved these changes
Dec 17, 2024
tvoran
previously approved these changes
Dec 17, 2024
Co-authored-by: Theron Voran <[email protected]>
yhyakuna
dismissed stale reviews from tvoran and jonathanfrappier
via
December 17, 2024 05:43
227aad7
tvoran
approved these changes
Dec 17, 2024
jonathanfrappier
approved these changes
Dec 17, 2024
6 tasks
Monkeychip
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Fix style inconsistency * Fix typos * Update website/content/docs/platform/k8s/vso/secret-transformation.mdx Co-authored-by: Jonathan Frappier <[email protected]> * Update website/content/docs/platform/k8s/helm/terraform.mdx Co-authored-by: Theron Voran <[email protected]> * Update website/content/docs/platform/k8s/injector/annotations.mdx Co-authored-by: Theron Voran <[email protected]> --------- Co-authored-by: Jonathan Frappier <[email protected]> Co-authored-by: Theron Voran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.18.x
docs
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
pr/no-changelog
pr/no-milestone
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
Going through the front matter and fix inconsistencies:
helm
should beHelm
(Helm docs)lambda
should beLambda
(AWS docs)Vault enterprise
should beVault Enterprise
Vault agent
should beVault Agent
Match the
page_titile
value with the H1 header if they are differentTODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.