Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix style inconsistency #29199

Merged
merged 8 commits into from
Dec 17, 2024
Merged

[DOCS] Fix style inconsistency #29199

merged 8 commits into from
Dec 17, 2024

Conversation

yhyakuna
Copy link
Contributor

@yhyakuna yhyakuna commented Dec 16, 2024

Description

What does this PR do?

Going through the front matter and fix inconsistencies:

  • helm should be Helm (Helm docs)

  • lambda should be Lambda (AWS docs)

  • Vault enterprise should be Vault Enterprise

  • Vault agent should be Vault Agent

  • Match the page_titile value with the H1 header if they are different

    image

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@yhyakuna yhyakuna self-assigned this Dec 16, 2024
@yhyakuna yhyakuna requested review from a team as code owners December 16, 2024 19:38
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 16, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

tvoran
tvoran previously approved these changes Dec 17, 2024
website/content/docs/platform/k8s/helm/terraform.mdx Outdated Show resolved Hide resolved
website/content/docs/platform/k8s/injector/annotations.mdx Outdated Show resolved Hide resolved
@yhyakuna yhyakuna dismissed stale reviews from tvoran and jonathanfrappier via 227aad7 December 17, 2024 05:43
@yhyakuna yhyakuna merged commit ed46640 into main Dec 17, 2024
33 of 34 checks passed
@yhyakuna yhyakuna deleted the docs/plugin-docs-seo branch December 17, 2024 16:01
Monkeychip pushed a commit that referenced this pull request Dec 18, 2024
* Fix style inconsistency

* Fix typos

* Update website/content/docs/platform/k8s/vso/secret-transformation.mdx

Co-authored-by: Jonathan Frappier <[email protected]>

* Update website/content/docs/platform/k8s/helm/terraform.mdx

Co-authored-by: Theron Voran <[email protected]>

* Update website/content/docs/platform/k8s/injector/annotations.mdx

Co-authored-by: Theron Voran <[email protected]>

---------

Co-authored-by: Jonathan Frappier <[email protected]>
Co-authored-by: Theron Voran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants