Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph: update test output for v1.7 #424

Merged
merged 1 commit into from
Nov 29, 2023
Merged

graph: update test output for v1.7 #424

merged 1 commit into from
Nov 29, 2023

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Nov 29, 2023

As of hashicorp/terraform#34288 (due to land in v1.7.0) the output of terraform graph has changed again, now producing a compact graph containing only resource nodes.

@kmoe kmoe requested a review from radeksimko November 29, 2023 11:14
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

containing only resource nodes

That makes sense given that providers never actually participated in the graph anyway. I still find it confusing though when "resource" is used as an umbrella term for both resources and data sources. 😅

Read as: I was close to asking why would we exclude data sources, before reading through the PR.

@kmoe
Copy link
Member Author

kmoe commented Nov 29, 2023

@radeksimko Ah yes, the eternal ambiguity between "resource" and "managed resource", not always helped by the (rare) disambiguating term "data resource"...

@kmoe kmoe merged commit a2bb72f into main Nov 29, 2023
70 checks passed
@kmoe kmoe deleted the kmoe/graph-1.7.0 branch November 29, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants