Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add podLabels value to add custom labels to operator pods #522

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

mlflr
Copy link
Contributor

@mlflr mlflr commented Nov 21, 2024

Description

This PR adds podLabels value that is added to pod labels of operator deployment as is customary in most helm charts.
In many organizations it is mandatory to have specific labels in order to facilitate for, for example, cost allocation or log ingestion

Usage Example

adding this to values file:

podLabels:
  test: xxx
  test2: yyy

results in deployment having:

apiVersion: apps/v1
kind: Deployment
...
spec:
  ...
  template:
    metadata:
      labels:
        ...
        test: xxx
        test2: yyy
...

References

N/A

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@mlflr mlflr requested a review from a team as a code owner November 21, 2024 14:38
Copy link

hashicorp-cla-app bot commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mlflr!

Thank you for your interest in contributing to this project!

Could you please do the following steps to complete it?

  • Update Helm chart documentation. Please, execute make helm-docs.
  • Add a change log entry:
    $ changie new --kind ENHANCEMENTS --custom "PR=522" --body '`Helm Chart`: Add the ability to configure additional labels for the Operator pod.'

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 1, 2024
@mlflr
Copy link
Contributor Author

mlflr commented Dec 1, 2024

done

Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mlflr! 🚀

@arybolovlev arybolovlev merged commit 358c315 into hashicorp:main Dec 2, 2024
6 checks passed
@mlflr mlflr deleted the helm-operator-podlabels branch December 2, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm-chart size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants