Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix Workspace validation #504

Merged
merged 5 commits into from
Nov 27, 2024
Merged

🐛 Fix Workspace validation #504

merged 5 commits into from
Nov 27, 2024

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Oct 24, 2024 •
edited
Loading

Description

Fix an issue where spec.agentPool can be set even when spec.executionMode is not set to agent.

Tests

  • E2E on HCP Terraform Operator
  • E2E on HCP Terraform Operator [Helm]
  • E2E on Terraform Enterprise
  • E2E on Terraform Enterprise [Helm]

Usage Example

N/A.

References

N/A.

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@arybolovlev arybolovlev added this to the v2.7.1 milestone Oct 24, 2024
@arybolovlev arybolovlev marked this pull request as ready for review November 7, 2024 15:12
@arybolovlev arybolovlev requested a review from a team as a code owner November 7, 2024 15:12
@arybolovlev arybolovlev merged commit bcf8308 into main Nov 27, 2024
6 checks passed
@arybolovlev arybolovlev deleted the fix-workspace-validation branch November 27, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahFrench SarahFrench SarahFrench approved these changes

Assignees
No one assigned
Labels
api golang size/XS test
Projects
None yet
Milestone
v2.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@arybolovlev @SarahFrench