Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add --module-sync-period CLI option #480

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Aug 30, 2024

Description

This PR introduces a new CLI option called --module-sync-period along with a corresponding controllers.module.syncPeriod Helm chart option. It sets the time interval for re-queuing Module resources instead of pulling them all at once for reconciliation. This change helps distribute the workload of the Module controller more evenly, especially when managing a large number of resources.

Tests

  • E2E on HCP Terraform Operator
  • E2E on HCP Terraform Operator [Helm]
  • E2E on Terraform Enterprise
  • E2E on Terraform Enterprise [Helm]

Usage Example

$ helm upgrade this hashicorp/hcp-terraform-operator --set controllers.module.syncPeriod=30m

References

N/A.

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart golang controller size/XS labels Aug 30, 2024
@arybolovlev arybolovlev marked this pull request as ready for review August 30, 2024 07:15
@arybolovlev arybolovlev requested a review from a team as a code owner August 30, 2024 07:15
main.go Show resolved Hide resolved
Copy link
Contributor

@sheneska sheneska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! 👍🏻

@arybolovlev arybolovlev merged commit 18ca0b5 into main Sep 5, 2024
11 checks passed
@arybolovlev arybolovlev deleted the add-module-sync-period branch September 5, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller documentation Improvements or additions to documentation golang helm-chart size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants