Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add checksum and account id support #1491

Merged
merged 12 commits into from
Jan 29, 2025

Conversation

icoxxx
Copy link
Contributor

@icoxxx icoxxx commented Jan 28, 2025

Description:
Checksums now appear wherever an account is loaded or entered in the app.
For data entry (add account) - it adds the checksum on blur of the input, showed in format like: 0.0.1234-abcde

Related issue(s):

#1426

@icoxxx icoxxx self-assigned this Jan 28, 2025
@icoxxx icoxxx requested review from SvetBorislavov, yiliev0 and a team as code owners January 28, 2025 14:39
@icoxxx icoxxx linked an issue Jan 28, 2025 that may be closed by this pull request
@icoxxx icoxxx requested a review from SimiHunjan January 28, 2025 14:39
@SvetBorislavov SvetBorislavov changed the title 1426 add checksum and account id support feat: add checksum and account id support Jan 29, 2025
@icoxxx icoxxx force-pushed the 1426-add-checksum-and-account-id-support branch from 5a219db to 839f97e Compare January 29, 2025 14:10
Copy link
Contributor

@yiliev0 yiliev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When building the app, I get ESLint warnings for unused variables: watch in AccountIdInput.vue and useAccountId in AppAutoComplete.vue. Could you check them out?

@yiliev0 yiliev0 force-pushed the 1426-add-checksum-and-account-id-support branch from 839f97e to 60b2f0a Compare January 29, 2025 14:54
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
@SvetBorislavov SvetBorislavov merged commit b7596a4 into main Jan 29, 2025
15 checks passed
@SvetBorislavov SvetBorislavov deleted the 1426-add-checksum-and-account-id-support branch January 29, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add checksum and account ID support
3 participants