-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add checksum and account id support #1491
Merged
SvetBorislavov
merged 12 commits into
main
from
1426-add-checksum-and-account-id-support
Jan 29, 2025
Merged
feat: add checksum and account id support #1491
SvetBorislavov
merged 12 commits into
main
from
1426-add-checksum-and-account-id-support
Jan 29, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icoxxx
requested review from
SvetBorislavov,
yiliev0 and
a team
as code owners
January 28, 2025 14:39
SvetBorislavov
changed the title
1426 add checksum and account id support
feat: add checksum and account id support
Jan 29, 2025
icoxxx
force-pushed
the
1426-add-checksum-and-account-id-support
branch
from
January 29, 2025 14:10
5a219db
to
839f97e
Compare
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Yordan Iliev <[email protected]>
yiliev0
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When building the app, I get ESLint warnings for unused variables: watch
in AccountIdInput.vue
and useAccountId
in AppAutoComplete.vue
. Could you check them out?
yiliev0
force-pushed
the
1426-add-checksum-and-account-id-support
branch
from
January 29, 2025 14:54
839f97e
to
60b2f0a
Compare
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
SvetBorislavov
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checksums now appear wherever an account is loaded or entered in the app.
For data entry (add account) - it adds the checksum on blur of the input, showed in format like: 0.0.1234-abcde
Related issue(s):
#1426