feat: network notification badges #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icoxxx
requested review from
SvetBorislavov,
yiliev0 and
a team
as code owners
SvetBorislavov
requested changes
Jan 27, 2025
front-end/src/renderer/pages/Settings/components/GeneralTab/components/NetworkSettings.vue
Outdated
Show resolved
Hide resolved
SvetBorislavov
previously approved these changes
Jan 27, 2025
icoxxx
force-pushed
the
1449-notification-badge-on-network
branch
from
d6e98e8 to
851ac1d
Compare
SvetBorislavov
force-pushed
the
1449-notification-badge-on-network
branch
from
87e1b3c to
abdf9e1
Compare
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
icoxxx
force-pushed
the
1449-notification-badge-on-network
branch
from
abdf9e1 to
8ec79c0
Compare
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
SvetBorislavov
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces the additionalData property (optional) to the Notification entity. The feature includes backend and frontend changes. Network specific notifications are now displayed alongside the network label and in settings - networks
Backend Updates:
Added the additionalData property to the Notification entity, emitted during the creation of a transaction.
Updated the backend services to handle this new property appropriately.
Modified backend tests to include the new additionalData field, ensuring proper test coverage.
Frontend Implementation:
Integrated the additionalData logic into the notificationStore to manage and display notifications effectively.
Enhanced the ButtonGroup component to support an optional parameter for handling dynamic notifications.
Created a custom ::after pseudo-class to style badges in the Settings - Networks section, ensuring badges do not affect the layout or alignment of other elements in the group.
Related issue(s):
#1449