Skip to content

Commit

Permalink
dkim_sign: use get_decoded instead of header.get (#2540)
Browse files Browse the repository at this point in the history
* dkim_sign: use get_decoded instead of header.get
* depend on newer haraka-test-fixtures with get_decoded
* bump test-fixtures version
  • Loading branch information
msimerson authored Nov 17, 2018
1 parent 070e0fe commit 8cda233
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ coverage
.idea
tests/queue/plain
tests/queue/multibyte
package-lock.json
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
},
"devDependencies": {
"nodeunit" : "*",
"haraka-test-fixtures" : ">=1.0.24",
"haraka-test-fixtures" : ">=1.0.27",
"eslint" : ">=3",
"eslint-plugin-haraka" : "*",
"nodemailer" : "*"
Expand Down
2 changes: 1 addition & 1 deletion plugins/dkim_sign.js
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ exports.get_sender_domain = function (connection) {

// the DKIM signing key should be aligned with the domain in the From
// header (see DMARC). Try to parse the domain from there.
const from_hdr = txn.header.get('From');
const from_hdr = txn.header.get_decoded('From');
if (!from_hdr) return domain;

// The From header can contain multiple addresses and should be
Expand Down

0 comments on commit 8cda233

Please sign in to comment.