Warn instead of failing when asset check fails #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we get network errors when making requests. Most endpoints are retried but the assets-data check is only performed once. When it fails with a non-404 response, the execution halts. We can improve this by instead assuming the assets are not there and continue as if we had a 404. I've added a warning log just to make sure we surface this issue.
lencioni
approved these changes
May 16, 2024
lencioni
reviewed
May 16, 2024
src/remoteRunner.js
Outdated
| @@ -94,7 +94,13 @@ async function uploadStaticPackage({ | |||
| return assetsDataRes.path; | |||
| } catch (e) { | |||
| if (e.statusCode !== 404) { | |||
| throw e; | |||
| logger.warn( | |||
There was a problem hiding this comment.
I think we need to make this change in more places, like domRunner.js
We had asset upload code in two places, and I only patched one of them in my initial attempt. Bringing them in closer will make it easier to refactor and we avoid duplicated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we get network errors when making requests. Most endpoints are retried but the assets-data check is only performed once. When it fails with a non-404 response, the execution halts. We can improve this by instead assuming the assets are not there and continue as if we had a
404. I've added a warning log just to make sure we surface this issue.