Add data-happo-ignore to root element #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will cause it to be excluded from the rectangle calculation when used with prerender:false. When migrating one of my projects from prerender:true to prerender:false I noticed that there was an extra rectangle around smaller examples. Turns out the root element was causing this. In a prerender:true world, we grab the innerHTML of this root node so it isn't present in rendering on Happo workers.
And also fix the value of the attr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cause it to be excluded from the rectangle calculation when used with prerender:false.
When migrating one of my projects from prerender:true to prerender:false I noticed that there was an extra rectangle around smaller examples. Turns out the root element was causing this. In a prerender:true world, we grab the innerHTML of this root node so it isn't present in rendering on Happo workers.