Improve error message when unable to resolve GITHUB_EVENT_PATH #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message here was a bit cryptic: ``` Error: Cannot find module '/path/to/some/file.json' Require stack: - /e2e/node_modules/happo-e2e/src/resolveEnvironment.js ... ``` I want to make it easier for people to troubleshoot this on their own. I think we can try/catch the require and provide a clearer error message that helps people understand that something may be up with the GITHUB_EVENT_PATH environment variable.
lencioni
force-pushed
the
resolve-env-error
branch
from
ba0fa94 to
39a9b61
Compare
trotzig
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message here was a bit cryptic:
I want to make it easier for people to troubleshoot this on their own. I think we can try/catch the require and provide a clearer error message that helps people understand that something may be up with the GITHUB_EVENT_PATH environment variable.