Support dynamic partition and ad-hoc cep runtime #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haoch Please help to review this PR, thanks |
haoch
requested changes
Jan 15, 2019
| @@ -298,37 +324,42 @@ public ExecutionSiddhiStream(DataStream<Tuple2<String, Object>> dataStream, Stri | |||
| * @param <T> Output type | |||
| * @return Return output stream as POJO class. | |||
| */ | |||
| public <T> DataStream<T> returns(String outStreamId, Class<T> outType) { | |||
| public <T> DataStream<Tuple2<String, T>> returns(String outStreamId, Class<T> outType) { | |||
There was a problem hiding this comment.
Please keep DataStream<T> instead of DataStream<Tuple2<String, T>> for backward compatibility and the String key is verbose as well.
| } | ||
|
|
||
| public DataStream<Row> returnAsRow(String outStreamId) { | ||
| return this.returnsInternal(outStreamId, TypeExtractor.createTypeInfo(Row.class)); | ||
| public DataStream<Tuple2<String, Row>> returnAsRow(String outStreamId) { |
There was a problem hiding this comment.
Please keep DataStream<T> instead of DataStream<Tuple2<String, T>> for backward compatibility
| @@ -284,12 +304,18 @@ public ExecutionSiddhiStream(DataStream<Tuple2<String, Object>> dataStream, Stri | |||
| * @see java.util.LinkedHashMap | |||
| */ | |||
| public DataStream<Map<String, Object>> returnAsMap(String outStreamId) { | |||
| } | ||
|
|
||
| /** | ||
| * @param outStreamId OutStreamId | ||
| * @param <T> Output type | ||
| * @return Return output stream as POJO class. | ||
| */ | ||
| public <T> DataStream<T> returns(String outStreamId, TypeInformation<T> typeInformation) { | ||
| return returnsInternal(outStreamId, typeInformation); | ||
| public <T> DataStream<Tuple2<String, T>> returns(String outStreamId, TypeInformation<T> typeInformation) { |
There was a problem hiding this comment.
Please keep DataStream<T> instead of DataStream<Tuple2<String, T>> for backward compatibility
|
@wujinhu Please keep the original API for backward compasibility and add some new API for multiple stream output. |
|
@haoch OK, I have brought interfaces back and added new interfaces. |
|
haoch
approved these changes
Jan 16, 2019
|
LGTM @wujinhu. Do you think it's ready to merge now? |
haoch
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dynamic partition for dynamic added rules
Related Issue: #19 #2