wallet-http: Return total number of transactions zapped. #920
+131
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nodech
commented
Jan 17, 2025
nodech
commented
- minor: Track and return total number of transactions being zapped. This can help users reason about the result of their actions, w/o this users can't track the results of the process.
- Don't accumulate hashes and return in wallet. This could lead to too much memory being used if the number of pending transactions is a lot. This list of hashes is not being used anywhere either.
- Fix Transaction Options not properly taking into account network of the node.
nodech
added
wallet-http
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.