Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed CI was breaking due to dry-system (from github) requiring a version of dry-auto_inject that's not released on RubyGems yet. So I added that... then realized I could actually remove both from the Gemfile, since dry-system's github source was added to get access to v1.1 before it was released on RubyGems. We don't need that anymore afaict.
I also went further and removed the github source for dry-files and dry-logger, since I don't think they're needed anymore. CI passes without them, and I think it's simpler to only depend on released gems (and the github source can always be re-added as necessary).
And thinking at a higher level / planning for the future, while we'll sometimes need to add github source to dry-rb gems in hanami repos, but I think we should remove those once they're not needed. (Compared to hanami gems, which can always reference main, so we stay up to date). WDYT @timriley @flash-gordon?