Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.4 support #32

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Ruby 3.4 support #32

wants to merge 4 commits into from

Conversation

cllns
Copy link
Member

@cllns cllns commented Jan 6, 2025

I noticed CI was breaking due to dry-system (from github) requiring a version of dry-auto_inject that's not released on RubyGems yet. So I added that... then realized I could actually remove both from the Gemfile, since dry-system's github source was added to get access to v1.1 before it was released on RubyGems. We don't need that anymore afaict.

I also went further and removed the github source for dry-files and dry-logger, since I don't think they're needed anymore. CI passes without them, and I think it's simpler to only depend on released gems (and the github source can always be re-added as necessary).

And thinking at a higher level / planning for the future, while we'll sometimes need to add github source to dry-rb gems in hanami repos, but I think we should remove those once they're not needed. (Compared to hanami gems, which can always reference main, so we stay up to date). WDYT @timriley @flash-gordon?

@cllns cllns requested a review from timriley January 6, 2025 21:50
@flash-gordon
Copy link
Member

@cllns I usually add them when needed and then remove them. We can have a dedicated plan that always runs against git versions (configured via env vars). The only problem is when you prepare a new version that depends on an unreleased gem, the builds will fail until the version is released. We could automate this with a helper available in gemfiles.

if ENV['USE_GIT_DEPS']
  define_deps_from_git # Ideally, this analyses deps and adds `git dep, github: ...`
end

@flash-gordon
Copy link
Member

Oh, also I'm working on dry-auto_inject rn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants