Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme with basic installation instructions. #8

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Updated readme with basic installation instructions. #8

merged 1 commit into from
Aug 14, 2018

Conversation

kbondanza
Copy link
Contributor

@kbondanza kbondanza commented Aug 13, 2018

Updated readme with basic installation instructions, and updated npm version number to match version number in package.json.


This change is Reviewable

@kbondanza
Copy link
Contributor Author

I saw this enhancement issue: #7 and the twitter discussion. Should I remove the recommendation, basic webpack config steps I added? I was thinking, of how I was confused at first, and made some unsuccessful installation attempts with CRA and Parcel Apps.

@hamlim
Copy link
Owner

hamlim commented Aug 14, 2018

Sorry for the delay, thanks for the PR.

Lets keep the webpack notes, I think that issue #7 will be an enhancement on top of regular wepack setups.

Any CRA setup will need to be using a v2 alpha since that is when they add support for babel-plugin-macros.

@hamlim hamlim merged commit 8aab769 into hamlim:master Aug 14, 2018
@kbondanza
Copy link
Contributor Author

Yeah, I did some research while learning/debugging the other day and learned that although the alpha versions do compile node_modules by default they only do for standard language features.

https://github.com/facebook/create-react-app/blob/next/packages/react-scripts/config/webpack.config.dev.js#L260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants