Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bash expansion in kubeconfig path of CLI script #63

Merged
merged 2 commits into from
May 8, 2024
+3 −4
Merged

Fix Bash expansion in kubeconfig path of CLI script #63

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8313374
Fix $HOME expansion in CLI script
pizzapim May 7, 2024
958eeb8
Allow overwriting kubeconfig at run-time of CLI script
pizzapim May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pkgs/kubenix.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,10 @@ symlinkJoin {
passthru.manifest = result;

postBuild = ''
export DIFF="${diff}"
wrapProgram $out/bin/kubenix \
--set PATH "$out/bin" \
--set KUBECONFIG "${kubeconfig}" \
--set KUBECTL_EXTERNAL_DIFF "''${DIFF}" \
--set MANIFEST "${result}"
--run 'export KUBECONFIG=${kubeconfig}' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this, so user can still overwrite KUBECONFIG at runtime?

Suggested change
--run 'export KUBECONFIG=${kubeconfig}' \
--run 'export KUBECONFIG=''${KUBECONFIG:-${kubeconfig}}' \

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

--set KUBECTL_EXTERNAL_DIFF '${diff}' \
--set MANIFEST '${result}'
'';
}
Loading