-
Notifications
You must be signed in to change notification settings - Fork 47
Commit
…nts. Otherwise we get a debug, non-optimized build, which is almost certainly not what we want to build recipies with.
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -318,6 +318,28 @@ def getShellVariableSetters(shellVariables): | |
$configure $dirArgs $buildSpec $@ | ||
} | ||
# helper function to validate CMake invocations (and use the correct one) | ||
cmake() | ||
{ | ||
if [[ "$*" != *CMAKE_BUILD_TYPE* ]]; then | ||
echo "error: invoking cmake without CMAKE_BUILD_TYPE specified" | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
korli
Contributor
|
||
exit 1 | ||
fi | ||
$portPackageLinksDir/cmd~cmake/bin/cmake $* | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
tqh
|
||
} | ||
# helper function to validate Meson invocations (and use the correct one) | ||
meson() | ||
{ | ||
if [[ "$*" != *buildtype* ]]; then | ||
echo "error: invoking meson without --buildtype argument" | ||
exit 1 | ||
fi | ||
$portPackageLinksDir/cmd~meson/bin/meson $* | ||
} | ||
fixDevelopLibDirReferences() | ||
{ | ||
# Usage: fixDevelopLibDirReferences <file> ... | ||
|
3 comments
on commit cf89615
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it behaves as intended, but can't really check until I fix all packages:
error: invoking cmake without CMAKE_BUILD_TYPE specified! note: you probably want -DCMAKE_BUILD_TYPE=Release or -DCMAKE_BUILD_TYPE=RelWithDebInfo Command '['bash', '-c', '. /home/frho/haiku-clean/haiku/arm64/objects/haiku/arm64/packaging/repositories/HaikuPortsCross-build/dev-libs/libsolv_bootstrap/work-0.3.0_haiku_2014_12_22/wrapper-script']' returned non-zero exit status 1.
I ran into this, and I wish the error message was as descriptive as the commit message. So maybe clarify?