Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signing code is messy.
The setup function is not
ptls_minicrypto_init_secp256r1sha256_sign_certificate()
but the privatekey parserptls_set_ecdsa_private_key()
.Wrapped in
ptls_minicrypto_load_private_key()
.ptls_minicrypto_secp256r1sha256_sign_certificate_t
is exported inminicrypto.h
.The call stack should be:
ptls_minicrypto_sign_cert()
->load + parse private-key
-> setup according to key OID.Changes:
Rename:
uecc.c
tosign.c
Move:
ptls_set_ecdsa_private_key()
tosign.c
Inline:
ptls_minicrypto_init_secp256r1sha256_sign_certificate()
intoptls_set_ecdsa_private_key()
Move:
ptls_minicrypto_secp256r1sha256_sign_certificate_t
fromminicrypto.h
tosign.c
Add new API:
ptls_minicrypto_init_sign_certificate()
andptls_minicrypto_dispose_sign_certificate()
This pull request breaks the current signing API.