removed old version number and replaced repo by 'current' version #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protoism
reviewed
Nov 27, 2024
README.md
Outdated
| @@ -53,18 +42,11 @@ The Eclipse repositories for this plugin. | |||
| Release update site. | |||
|
|
|||
| * [Eclipse Marketplace entry for the GWT Plugin](https://marketplace.eclipse.org/content/gwt-plugin) | |||
| * [Update sites for the GWT Plugin](https://plugins.gwtproject.org/eclipse/gwt-eclipse-plugin/) | |||
| * [Update sites for the GWT Plugin](https://gwt-plugins.github.io/documentation/repo/site/current/) | |||
There was a problem hiding this comment.
I'm really not sure that github a pages is a good place for storing eclipse plugins
| @@ -100,7 +82,7 @@ Creating a release requires signing artifacts. Set the following environment var | |||
| ### Deploy | |||
| Releases are uploaded as zips to the [release](https://github.com/gwt-plugins/gwt-eclipse-plugin/releases/) | |||
There was a problem hiding this comment.
I don't follow.
What files are on plugins.gwtproject.org/eclipse/gwt-eclipse-plugin?
What files are on gwt-plugins.github.io?
|
This PR is not complete, I believe... as the google pages hosting idea has been abandoned |
You're right, i need to fix that. |
protoism
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moved sponsors to the bottom of the page, because normal visitors will be more interested in installing the current version.