Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactors #5

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Major refactors #5

merged 5 commits into from
Jan 15, 2024

Conversation

gwleuverink
Copy link
Owner

  • Add tests for self evaluation local functions
  • Add IIFE documentation
  • Fix internal bundled module name collisions by making the script tag type module
  • Account for scenario where import has no exports, like an IIFE. No need to track internally
  • Make as prop optional, so IIFE Imports don't require a alias
  • Tests restructure & resilience refactor

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 98% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene

🚩 Declining Code Health (highest to lowest):

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 98% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene

🚩 Declining Code Health (highest to lowest):

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b95a89) 96.50% compared to head (354cf7e) 96.52%.
Report is 24 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main       #5      +/-   ##
============================================
+ Coverage     96.50%   96.52%   +0.02%     
  Complexity       29       29              
============================================
  Files             5        5              
  Lines           143      144       +1     
============================================
+ Hits            138      139       +1     
  Misses            5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 98% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene

@gwleuverink gwleuverink merged commit e5359a3 into main Jan 15, 2024
6 checks passed
@gwleuverink gwleuverink deleted the major-refactors branch January 21, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants