Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted px to rems in the base code. #1195

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Converted px to rems in the base code. #1195

wants to merge 5 commits into from

Conversation

fraincs
Copy link
Contributor

@fraincs fraincs commented Mar 13, 2023

Issue:

Summary

rem units not resizeable by user agent unless postcss-pxtorem is used - #1072

What I did

Converted px to rems in the base code.

How to test

This requires changing your browser basic font size for now.

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2023

⚠️ No Changeset found

Latest commit: 3ea5616

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 13, 2023

Deploy Preview for sg-orbit ready!

Name Link
🔨 Latest commit 3ea5616
🔍 Latest deploy log https://app.netlify.com/sites/sg-orbit/deploys/640fcdca44179a0008e5831b
😎 Deploy Preview https://deploy-preview-1195--sg-orbit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 13, 2023

Deploy Preview for sg-storybook ready!

Name Link
🔨 Latest commit 3ea5616
🔍 Latest deploy log https://app.netlify.com/sites/sg-storybook/deploys/640fcdcaed98220008a44422
😎 Deploy Preview https://deploy-preview-1195--sg-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patricklafrance
Copy link
Member

patricklafrance commented Mar 13, 2023

While it does make sense to use "rem" in Orbit components CSS codebase, I am not sure about using rem for documentation stories and event Chromatic stories as most people tend to think in term of pixels.

@fraincs
Copy link
Contributor Author

fraincs commented Mar 14, 2023

While it does make sense to use "rem" in Orbit components CSS codebase, I am not sure about using rem for documentation stories and event Chromatic stories as most people tend to think in term of pixels.

Great point. For the chromatic stories I was planning for the eventuality of testing rems in Chromatic too. It could be px too. As for documentation the idea is to support the users who change their font size even in documentation.

@alexasselin008 alexasselin008 changed the title Feature/1072 Converted px to rems in the base code. Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants