-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted px to rems in the base code. #1195
base: master
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for sg-orbit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for sg-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
While it does make sense to use "rem" in Orbit components CSS codebase, I am not sure about using rem for documentation stories and event Chromatic stories as most people tend to think in term of pixels. |
Great point. For the chromatic stories I was planning for the eventuality of testing rems in Chromatic too. It could be px too. As for documentation the idea is to support the users who change their font size even in documentation. |
Issue:
Summary
rem units not resizeable by user agent unless postcss-pxtorem is used - #1072
What I did
Converted px to rems in the base code.
How to test
This requires changing your browser basic font size for now.