Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjusting testing for GCS bucket existence check #3810

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Jan 27, 2025

Description

Adjusting mocking implementation to avoid global anonymous function in GCS bucket existence check, as discussed in #3756.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated GCS testing approach.

Migration Guide

Adjusting mocking implementation to avoid global anonymous function in GCS bucket existence check, as discussed in #3756.
@yhakbar yhakbar marked this pull request as ready for review January 27, 2025 17:49
@yhakbar yhakbar merged commit 41e8c07 into main Jan 27, 2025
4 of 6 checks passed
@yhakbar yhakbar deleted the fix/fixing-follow-up-work-from-3756 branch January 27, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants