-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stateful Session Affinity: Draining test #34
Conversation
1755173
to
d90e9d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied active conversations from grpc/grpc#34519
3ded4dd
to
30b018f
Compare
cdd8090
to
a664a13
Compare
cdd7ab3
to
498c524
Compare
Ported Richard's PR to the new repo. git apply ../34519.diff -p4 --whitespace=fix \ --exclude='**/gamma_server_runner.py' \ --exclude='**/xds_gamma_testcase.py' \ --exclude='**/affinity_test.py' \ --exclude='**/xds_k8s_testcase.py' ❯ git apply ../34519.diff -p4 -3 --include='**/xds_gamma_testcase.py' Plus manual conflict resolution ❯ git apply ../34519.diff -p4 -3 --include='**/gamma_server_runner.py' Plus manual conflict resolution ❯ git apply ../34519.diff -p4 -3 --include='**/affinity_test.py' Applied patch to 'tests/gamma/affinity_test.py' cleanly. ❯ git apply ../34519.diff -p4 -3 --include='**/xds_k8s_testcase.py' Plus manual conflict resolution
Also, fix some naming
59acbfe
to
84e2c53
Compare
Only drain test: All CSM tests: |
Only draining: All CSM: Other tests - verify no regressions: |
2fb61c2
to
66f87b7
Compare
Just in case, re-run with new prestop image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spent 45 minutes reviewing and I have basically no comments. Looks amazing! Thanks for taking care of this.
Adds CSM Stateful Session Affinity Draining test.
Note: the initial approach ported from @gnossen's PR grpc/grpc#34519, but it went through a lot of changes.