Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateful Session Affinity: Draining test #34

Merged
merged 49 commits into from
Mar 7, 2024

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Feb 9, 2024

Adds CSM Stateful Session Affinity Draining test.

Note: the initial approach ported from @gnossen's PR grpc/grpc#34519, but it went through a lot of changes.

Copy link
Member Author

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied active conversations from grpc/grpc#34519

framework/rpc/grpc_testing.py Outdated Show resolved Hide resolved
framework/infrastructure/k8s.py Outdated Show resolved Hide resolved
tests/gamma/affinity_test.py Outdated Show resolved Hide resolved
framework/rpc/grpc_testing.py Outdated Show resolved Hide resolved
@sergiitk sergiitk force-pushed the ssa-draining-test branch 7 times, most recently from 3ded4dd to 30b018f Compare February 16, 2024 06:17
@sergiitk sergiitk force-pushed the ssa-draining-test branch 2 times, most recently from cdd8090 to a664a13 Compare February 20, 2024 18:05
@sergiitk sergiitk force-pushed the ssa-draining-test branch 4 times, most recently from cdd7ab3 to 498c524 Compare February 22, 2024 20:56
Ported Richard's PR to the new repo.

git apply ../34519.diff -p4 --whitespace=fix \
  --exclude='**/gamma_server_runner.py' \
  --exclude='**/xds_gamma_testcase.py' \
  --exclude='**/affinity_test.py' \
  --exclude='**/xds_k8s_testcase.py'

❯ git apply ../34519.diff -p4 -3 --include='**/xds_gamma_testcase.py'
Plus manual conflict resolution

❯ git apply ../34519.diff -p4 -3 --include='**/gamma_server_runner.py'
Plus manual conflict resolution

❯ git apply ../34519.diff -p4 -3 --include='**/affinity_test.py'
Applied patch to 'tests/gamma/affinity_test.py' cleanly.

❯ git apply ../34519.diff -p4 -3 --include='**/xds_k8s_testcase.py'
Plus manual conflict resolution
@sergiitk sergiitk force-pushed the ssa-draining-test branch from 59acbfe to 84e2c53 Compare March 6, 2024 02:17
@sergiitk
Copy link
Member Author

sergiitk commented Mar 7, 2024

Only drain test:

All CSM tests:

@sergiitk sergiitk marked this pull request as ready for review March 7, 2024 06:33
@sergiitk sergiitk requested a review from gnossen March 7, 2024 06:33
@sergiitk
Copy link
Member Author

sergiitk commented Mar 7, 2024

@sergiitk sergiitk force-pushed the ssa-draining-test branch from 2fb61c2 to 66f87b7 Compare March 7, 2024 19:53
@sergiitk
Copy link
Member Author

sergiitk commented Mar 7, 2024

Just in case, re-run with new prestop image:

Copy link
Collaborator

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spent 45 minutes reviewing and I have basically no comments. Looks amazing! Thanks for taking care of this.

framework/rpc/grpc_testing.py Show resolved Hide resolved
@sergiitk sergiitk merged commit 1e0a9ec into grpc:main Mar 7, 2024
6 checks passed
@sergiitk sergiitk deleted the ssa-draining-test branch March 7, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants