Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(minor) Remove extra newlines in o11y query helper #31

Merged
merged 1 commit into from
Feb 2, 2024
Merged

(minor) Remove extra newlines in o11y query helper #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/gamma/csm_observability_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,6 @@ def query_metrics(
A helper function to make the cloud monitoring API call to query
metrics created by this test run.
"""

# Based on default retry settings for list_time_series method:
# https://github.com/googleapis/google-cloud-python/blob/google-cloud-monitoring-v2.18.0/packages/google-cloud-monitoring/google/cloud/monitoring_v3/services/metric_service/transports/base.py#L210-L218
# Modified: predicate extended to retry on a wider range of error types.
Expand All @@ -420,7 +419,6 @@ def query_metrics(
),
deadline=90.0,
)

results = {}
for metric in metric_names:
logger.info("Requesting list_time_series for metric %s", metric)
Expand Down
Loading