Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSM O11y: improve the retry settings of list_time_series API call #30

Merged
merged 1 commit into from
Feb 2, 2024
Merged

CSM O11y: improve the retry settings of list_time_series API call #30

merged 1 commit into from
Feb 2, 2024

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Feb 2, 2024 •
edited
Loading

Extends the retry conditions for metric_client.list_time_series call in csm_observability_test:

  • Retry on HTTP 5xx + corresponding gRPC statuses. Previously only retried on 503 ServiceUnavailable.
  • Retry on HTTP 429 / gRPC ResourceExhausted. The error indicates the request is rate limited, so we want to retry.

Ref Default retry settings.

@sergiitk sergiitk requested a review from yashykt February 2, 2024 21:57
@sergiitk
Copy link
Member Author

sergiitk commented Feb 2, 2024

cc @stanley-cheung

@sergiitk
Copy link
Member Author

sergiitk commented Feb 2, 2024 •
edited
Loading

@sergiitk sergiitk enabled auto-merge (squash) February 2, 2024 22:54
@sergiitk sergiitk merged commit 49d4851 into grpc:main Feb 2, 2024
6 checks passed
@sergiitk sergiitk deleted the retry-list_time_series branch February 2, 2024 22:58
@sergiitk sergiitk mentioned this pull request Feb 2, 2024
Merged
sergiitk added a commit that referenced this pull request Feb 2, 2024
@sergiitk
(minor) Remove extra newlines in o11y query helper (#31)
835fcca 
Late review fixes for #30.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

@yashykt yashykt yashykt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiitk @yashykt @stanley-cheung