Paramatize request/response payload size #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
requested changes
Jan 17, 2024
stanley-cheung
force-pushed
the
paramatize_payload_size
branch
from
7294edf to
cd4186a
Compare
sergiitk
force-pushed
the
paramatize_payload_size
branch
from
cd4186a to
f745916
Compare
sergiitk
reviewed
Jan 26, 2024
sergiitk
force-pushed
the
paramatize_payload_size
branch
from
f745916 to
6bdfc40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the xds interop client is sending an empty payload for the
UnaryCallrpc. Since testing CSM Observability will need a non-trivial payload (e.g. to verify the metrics about the number of bytes being sent), this PR will try to add 2 parametersrequest_payload_sizeandresponse_payload_sizeto the client image to control the size of the payload to be sent. Each language will need to implement this parameter in their respective client image. The one for c++ is here.Note that we only need to set these 2 parameters (both
requestandresposnepayload size) on the client deployment because the client will in turn tell the server how much to send back.The good 'ol interop client already has these: https://github.com/grpc/grpc/blob/master/test/cpp/interop/interop_client.cc#L249-L251