Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csm: modify o11y test to use proxyless bootstrap injector #141

Merged
merged 12 commits into from
Dec 4, 2024
Merged

csm: modify o11y test to use proxyless bootstrap injector #141

merged 12 commits into from
Dec 4, 2024

Conversation

arvindbr8
Copy link
Member

@arvindbr8 arvindbr8 commented Nov 26, 2024 •
edited
Loading

As part of CSM Gateway for Mesh GA - we have already implemented a Proxyless Bootstrap Injector in GCP which will allow clusters that are onboarded to CSM Gateway for Mesh to get the following injected into the pod with the right labels:

  1. initContainer with TD Bootstrap Injector + volume Mount where the config output is generated
  2. CSM O11y related labels and envvars.

The test cluster also had to be updated to follow the new onboarding steps. I will create a CL internally to update the cluster creation script

Testing: here

@arvindbr8 arvindbr8 requested a review from a team as a code owner November 26, 2024 18:56
@arvindbr8
Copy link
Member Author

Testing the new cluster + test driver here

arvindbr8
arvindbr8 commented Nov 26, 2024
View reviewed changes
Copy link
Member Author

@arvindbr8 arvindbr8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last one failed for connectivity issues. I was able to verify that the injector added the CSM o11y env vars and also the bootstrap config to the volume mount.

Kicking off another run of the test suite:

@sergiitk sergiitk requested review from sergiitk and removed request for XuanWang-Amos December 2, 2024 20:13
sergiitk
sergiitk requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I'd like to avoid creating new templates, and just configure everything with deployment args. Let's talk IRL about how we can achieve that.

@arvindbr8
Copy link
Member Author

latest run after modifying api version

@arvindbr8 arvindbr8 self-assigned this Dec 2, 2024
@arvindbr8
Copy link
Member Author

arvindbr8 commented Dec 4, 2024 •
edited
Loading

Things are looking better -

Ideally I'd like to avoid creating new templates, and just configure everything with deployment args. Let's talk IRL about how we can achieve that.

discussed offline - will do this in a fast followup

@arvindbr8 arvindbr8 assigned sergiitk and unassigned arvindbr8 Dec 4, 2024
sergiitk
sergiitk approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if full CSM suite passes

tests/gamma/csm_observability_test_with_injection.py Outdated Show resolved Hide resolved
kubernetes-manifests/gamma/server.deployment.yaml Outdated Show resolved Hide resolved
@arvindbr8
Copy link
Member Author

arvindbr8 commented Dec 4, 2024 •
edited
Loading

Running the entire suite again -

@arvindbr8 arvindbr8 enabled auto-merge (squash) December 4, 2024 22:53
@arvindbr8 arvindbr8 merged commit 3e8a89b into grpc:main Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiitk sergiitk sergiitk approved these changes

Assignees

@sergiitk sergiitk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvindbr8 @sergiitk