Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use channelz to determine the ADS connections state #125

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Use channelz to determine the ADS connections state #125

merged 6 commits into from
Aug 19, 2024

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Aug 15, 2024 •
edited
Loading

This way we can detect when the client starts talking to an expected control plane. This makes the test more stable.

Test run

@eugeneo eugeneo requested a review from XuanWang-Amos August 15, 2024 23:44
@eugeneo eugeneo requested a review from a team as a code owner August 15, 2024 23:44
XuanWang-Amos
XuanWang-Amos reviewed Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@XuanWang-Amos XuanWang-Amos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test run to description.

framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
eugeneo
eugeneo commented Aug 16, 2024
View reviewed changes
Copy link
Contributor Author

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. I added a link to a successful run (with your comments addressed) into the PR description.

framework/helpers/docker.py Outdated Show resolved Hide resolved
framework/helpers/docker.py Outdated Show resolved Hide resolved
@eugeneo eugeneo merged commit 8616923 into grpc:main Aug 19, 2024
7 checks passed
@eugeneo eugeneo deleted the fallback-python branch August 19, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanWang-Amos XuanWang-Amos XuanWang-Amos approved these changes

Assignees

@XuanWang-Amos XuanWang-Amos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eugeneo @XuanWang-Amos