Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate with a Docker registry #124

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Aug 14, 2024

This looks like the last missing piece. I was able to run test to a completion on Kokoro with this patch.

Successful Run

@eugeneo eugeneo requested a review from XuanWang-Amos August 14, 2024 21:20
@eugeneo eugeneo requested a review from a team as a code owner August 14, 2024 21:20
Copy link
Collaborator

@XuanWang-Amos XuanWang-Amos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you attach the passed runs to description?

@eugeneo eugeneo merged commit 4d547c1 into grpc:main Aug 14, 2024
7 checks passed
@eugeneo eugeneo deleted the docker-auth branch August 14, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants