Add a thread to recreate the IPv6 firewall rule every 30 seconds to counteract the enforcer deleting it. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounteract the enforcer deleting it.
gnossen
reviewed
Aug 13, 2024
|
|
||
| def recreate_firewall_rule(): | ||
| time.sleep(30) | ||
| while self.firewall_rule_creation_should_stop is False: |
There was a problem hiding this comment.
Please use threading.Event for inter-thread synchronization. The current approach may suffer from tearing.
| source_range=self.firewall_source_range, | ||
| source_range_ipv6=self.firewall_source_range_ipv6, | ||
| ) | ||
| time.sleep(30) |
There was a problem hiding this comment.
Seems like this could be done with a single call to time.sleep
| source_range=self.firewall_source_range, | ||
| source_range_ipv6=self.firewall_source_range_ipv6, | ||
| ) | ||
| time.sleep(30) |
There was a problem hiding this comment.
Can the delay be pulled to a module-level constant? Also, 30 seems a bit slow to me. Maybe 10?
| @@ -128,6 +134,22 @@ def test_dualstack(self) -> None: | |||
| self.server_xds_host, self.server_xds_port | |||
| ) | |||
|
|
|||
| with self.subTest("_start_firewall_rule_creation_thread"): | |||
|
|
|||
| def recreate_firewall_rule(): | |||
There was a problem hiding this comment.
Seems like this functionality is generally useful. Can we just incorporate it into the --ensure_firewall flag?
|
No longer needed since the exemption is in place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short term fix to them not providing the exemption for the firewall rule.