Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dualstack support to the framework behind flag #101

Merged
merged 18 commits into from
Jul 23, 2024

Conversation

purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented Jul 8, 2024

Based on @larry-safran's proof of concept PR #88

@purnesh42H purnesh42H force-pushed the add-dualstack-support branch 2 times, most recently from 001d8aa to 4f0707d Compare July 8, 2024 17:14
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
kubernetes-manifests/server.deployment.yaml Outdated Show resolved Hide resolved
@purnesh42H purnesh42H force-pushed the add-dualstack-support branch from c9ac825 to 682e1db Compare July 9, 2024 09:32
@purnesh42H purnesh42H force-pushed the add-dualstack-support branch 2 times, most recently from cd91460 to ad73eca Compare July 10, 2024 15:29
@purnesh42H purnesh42H force-pushed the add-dualstack-support branch 5 times, most recently from 42e7a3d to dc31464 Compare July 10, 2024 17:05
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
@purnesh42H purnesh42H requested a review from larry-safran July 11, 2024 20:19
@purnesh42H
Copy link
Contributor Author

purnesh42H commented Jul 12, 2024

  • Successfully Run ./run.sh bin/run_td_setup.py without --add_dualstack_support flag
  • Successfully Run ./run.sh bin/run_td_setup.py --cmd=cleanup without --add_dualstack_support flag
  • Successfully Run ./run.sh bin/run_td_setup.py with --add_dualstack_support flag
  • Successfully Run ./run.sh bin/run_td_setup.py --cmd=cleanup with --add_dualstack_support flag

@purnesh42H
Copy link
Contributor Author

purnesh42H commented Jul 16, 2024

@purnesh42H purnesh42H force-pushed the add-dualstack-support branch 2 times, most recently from b879f09 to 6d66eaf Compare July 16, 2024 08:14
@purnesh42H purnesh42H requested a review from XuanWang-Amos July 16, 2024 19:05
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/xds_flags.py Outdated Show resolved Hide resolved
framework/infrastructure/gcp/api.py Outdated Show resolved Hide resolved
framework/infrastructure/gcp/compute.py Outdated Show resolved Hide resolved
framework/xds_flags.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/test_app/runners/k8s/k8s_base_runner.py Outdated Show resolved Hide resolved
@purnesh42H purnesh42H force-pushed the add-dualstack-support branch 3 times, most recently from f53f369 to 07bfab4 Compare July 17, 2024 18:29
@purnesh42H purnesh42H force-pushed the add-dualstack-support branch from 32e2354 to 44dd2a4 Compare July 20, 2024 06:54
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but give it another local run against the dual-stack cluster to polish the issues like the one with incorrect deletion orders. Then merge the current master into this branch, and re-run the tests. I'll give it another look early tomorrow.

@sergiitk
Copy link
Member

Oh, and please save the output of the local run - I'd like to give it a check in case we missed anything

@purnesh42H purnesh42H force-pushed the add-dualstack-support branch from 44dd2a4 to dd087fb Compare July 23, 2024 09:54
@purnesh42H
Copy link
Contributor Author

purnesh42H commented Jul 23, 2024

@sergiitk
Copy link
Member

@purnesh42H noticed that the jobs you ran weren't using this framework branch. Note the jobs I started above:

# [08:17:29 PDT] Parsed build request:
full_job_name: "grpc/java/v1.65.x/branch/psm-security"
scm_revision {
  github_scm_revision {
    commit_sha: "v1.65.x"
    name: "grpc-java"
    owner: "grpc"
    repository: "grpc-java"
  }
}
env_vars {
  key: "TEST_DRIVER_BRANCH"
  value: "add-dualstack-support"
}
env_vars {
  key: "TEST_DRIVER_REPO_OWNER"
  value: "purnesh42H"
}

Also - no need to run grpc/core/master/linux/grpc_xds_v3, this is legacy framework, which isn't affected by any changes to this repo.

@sergiitk
Copy link
Member

sergiitk commented Jul 23, 2024

Ah, my fault. For some reason I expected these env vars to show up in BUILD_CONFIG on this page: https://btx.cloud.google.com/invocations/88d2b23a-0c50-47f1-8b97-990496b008cd/details.

The jobs your started look right.

Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, except I suspect ClientDeploymentArgs won't work as we want to. Could you apply/accept suggestions I made, and I'll take a stab at getting the deployment args right.

framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/infrastructure/traffic_director.py Outdated Show resolved Hide resolved
framework/xds_k8s_testcase.py Show resolved Hide resolved
framework/xds_k8s_testcase.py Show resolved Hide resolved
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two items to address in the follow-up:

  1. Move server runner's enable_dualstack to ServerDeploymentArgs
  2. Fix the issue with deployment_args not merged in suites that override initKubernetesClientRunner, see https://github.com/grpc/psm-interop/pull/101/files#r1688415338

@sergiitk sergiitk merged commit 00199ac into grpc:main Jul 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants