Skip to content

Commit

Permalink
Fix bug with Gamma Server Runner not having GCP Logs link (#26)
Browse files Browse the repository at this point in the history
This fixes a bug with all the `GammaServerRunner` subclass not calling
the super class `KubernetesBaseRunner`'s `run()` method properly, which
causes the variable `self.time_start_requested` not being set and hence
there is never `RunHistory` logged for the gamma server runner.

ref b/298501683

---------

Co-authored-by: Sergii Tkachenko <[email protected]>
  • Loading branch information
stanley-cheung and sergiitk authored Jan 26, 2024
1 parent 37f27d7 commit 50ddddd
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions framework/test_app/runners/k8s/gamma_server_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

from framework.infrastructure import gcp
from framework.infrastructure import k8s
from framework.test_app.runners.k8s import k8s_base_runner
from framework.test_app.runners.k8s import k8s_xds_server_runner
from framework.test_app.server_app import XdsTestServer

Expand Down Expand Up @@ -134,14 +135,7 @@ def run( # pylint: disable=arguments-differ
False,
replica_count,
)
# super(k8s_base_runner.KubernetesBaseRunner, self).run()

if self.reuse_namespace:
self.namespace = self._reuse_namespace()
if not self.namespace:
self.namespace = self._create_namespace(
self.namespace_template, namespace_name=self.k8s_namespace.name
)
k8s_base_runner.KubernetesBaseRunner.run(self)

# Reuse existing if requested, create a new deployment when missing.
# Useful for debugging to avoid NEG loosing relation to deleted service.
Expand Down

0 comments on commit 50ddddd

Please sign in to comment.