Skip to content

Commit

Permalink
Log image name (#126)
Browse files Browse the repository at this point in the history
Minor change. I tested it locally so I don't waste Kokoro.

This change is helpful to confirm the tests are setup correctly.
  • Loading branch information
eugeneo authored Aug 29, 2024
1 parent 6ef4a97 commit 0e87a36
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions framework/helpers/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ def __init__(
manager: ProcessManager,
**config: types.ContainerConfig,
):
logger.info("Running image %s as [%s]", image, name)
self.name = name
self.config = Configure(config, image, name)
self.container = None
Expand Down
3 changes: 0 additions & 3 deletions tests/fallback_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,12 @@ def setUpClass():
)

def setUp(self):
logger.info("Starting %s", self.id())
self.process_manager = framework.helpers.docker.ProcessManager(
bootstrap=FallbackTest.bootstrap,
node_id=_NODE_ID.value,
)

def start_client(self, port: int = None, name: str = None):
logger.debug("Starting client process")
return framework.helpers.docker.Client(
manager=self.process_manager,
name=name or framework.xds_flags.CLIENT_NAME.value,
Expand All @@ -93,7 +91,6 @@ def start_client(self, port: int = None, name: str = None):
def start_control_plane(
self, name: str, port: int, upstream_port: int, cluster_name=None
):
logger.debug('Starting control plane "%s"', name)
return framework.helpers.docker.ControlPlane(
self.process_manager,
name=name,
Expand Down

0 comments on commit 0e87a36

Please sign in to comment.