Always include the 'SwiftProtobuf' import in generated code #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The 'SwiftProtobuf' import was missing from generated code. Modifications: - Always generate an import for 'SwiftProtobuf' Result: Import are more correct
rnro
approved these changes
Dec 3, 2024
glbrntt
added a commit
to glbrntt/grpc-swift-protobuf
that referenced
this pull request
Dec 4, 2024
Motivation: In (grpc#16) an import for SwiftProtobuf was added to account for well-known types. However, if no well-known types are used then warnings are emitted when the access level is included on the import. Modifications: - Only generate the SwiftProtobuf import for well-known types Result: Fewer warnings
glbrntt
added a commit
that referenced
this pull request
Dec 5, 2024
Motivation: In (#16) an import for SwiftProtobuf was added to account for well-known types. However, if no well-known types are used then warnings are emitted when the access level is included on the import. Modifications: - Only generate the SwiftProtobuf import for well-known types Result: Fewer warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The 'SwiftProtobuf' import was missing from generated code.
Modifications:
Result:
Import are more correct