chore(bazel): add MODULE.bazel files for bzlmod #144
Conversation
| ) | ||
|
|
||
| bazel_dep(name = "rules_proto", version = "6.0.0-rc2") | ||
| bazel_dep(name = "protobuf", version = "23.1", repo_name = "com_google_protobuf") |
There was a problem hiding this comment.
Can we not use 24.4 as used in WORKSPACE today?
There was a problem hiding this comment.
I'm afraid, it's not available on BCR yet
There was a problem hiding this comment.
23.1 was released May 2023. 23.2 was released the same month. 24.0 was released Aug 2023. And 25.0 was released Nov 2023. Looks like 23.1 was added to BCR at the very, very end of 2023.
Either BCR needs updating or we define the module locally (however that should be done). I can accept the skew, but we need to be able to choose something recent, so having this problem out-of-the-gate makes me think we need to go through that process now so we know how it is done.
There was a problem hiding this comment.
I'v tried importing it but then it requires a lot more bazel_deps which is quite bothering.
I believe BCR needs to be updated but I don't understand why it is not more for such a crucial dependency.
There was a problem hiding this comment.
Okay. Well, this PR is still a step in the right direction. We can use the older version for now.
mmorel-35
force-pushed
the
bzlmod
branch
2 times, most recently
from
b0bf3e0 to
3ea7aa6
Compare
|
I've remove the branch protection that required the |
Signed-off-by: Matthieu MOREL <[email protected]>
|
Thanks for the PR. Are you going to register this to BCR? |
I don't know how to do this |
|
@mmorel-35, thank you! |
Signed-off-by: Matthieu MOREL [email protected]