Examples: Updated HelloWorldServer using Executor #11850
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaspeaks
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
| private void start() throws IOException { | ||
| /* The port on which the server should run */ | ||
| int port = 50051; | ||
| server = Grpc.newServerBuilderForPort(port, InsecureServerCredentials.create()) | ||
| server = ServerBuilder.forPort(port) |
There was a problem hiding this comment.
We want people to use the Grpc.newServerBuilderForPort instead of ServerBuilder.forPort, so this change is wrong in addition to unnecessary. Both of the methods return a ServerBuilder<?>.
| @@ -58,6 +63,7 @@ public void run() { | |||
| private void stop() throws InterruptedException { | |||
| if (server != null) { | |||
| server.shutdown().awaitTermination(30, TimeUnit.SECONDS); | |||
| executor.shutdown(); | |||
There was a problem hiding this comment.
Since executor is created by the constructor rather than start(), you should do the executor.shutdown() in the shutdown hook. It would go both after the stop() and inside the catch block. The catch block should also call server.shutdownNow()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated HelloWorldServer Example using Executor
Fix: #2263