Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.70.0 #11843

Open
wants to merge 2 commits into
base: v1.70.x
Choose a base branch
from
Open

Release v1.70.0 #11843

wants to merge 2 commits into from

Conversation

shivaspeaks
Copy link
Member

No description provided.

@shivaspeaks
Copy link
Member Author

There are usually 3 commits in every grpc java Release. See this

Update README etc to reference 1.xx.x
Bump version to 1.xx.x
Bump version to 1.xx.x-SNAPSHOT

But in this PR, I don't see Update README etc... commit. But the changes of README are there. What went wrong? I did everything right this time by following RELEASING.md.

@shivaspeaks
Copy link
Member Author

Just understanding the reason,
Why should we NOT click the merge button on this PR? And why is it told to push using terminal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannanjgithub kannanjgithub kannanjgithub approved these changes

@ejona86 ejona86 Awaiting requested review from ejona86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivaspeaks @kannanjgithub