s2a: Add S2AStub cleanup handler. #11600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2024
Merged
|
@ejona86 , @larry-safran - does this implementation to make sure stub gets closed look ok? Relevant comment thread: #11113 (comment) |
larry-safran
reviewed
Oct 9, 2024
s2a/src/main/java/io/grpc/s2a/internal/handshaker/S2AProtocolNegotiatorFactory.java
Outdated
Show resolved
Hide resolved
s2a/src/main/java/io/grpc/s2a/internal/handshaker/S2AProtocolNegotiatorFactory.java
Outdated
Show resolved
Hide resolved
larry-safran
approved these changes
Oct 9, 2024
larry-safran
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
reviewed
Oct 9, 2024
s2a/src/main/java/io/grpc/s2a/internal/handshaker/S2AProtocolNegotiatorFactory.java
Outdated
Show resolved
Hide resolved
s2a/src/main/java/io/grpc/s2a/internal/handshaker/S2AProtocolNegotiatorFactory.java
Outdated
Show resolved
Hide resolved
rmehta19
force-pushed
the
s2a-close-stub
branch
3 times, most recently
from
b822f2c to
191ed07
Compare
rmehta19
force-pushed
the
s2a-close-stub
branch
from
191ed07 to
1698b54
Compare
ejona86
approved these changes
Oct 10, 2024
s2a/src/test/java/io/grpc/s2a/internal/handshaker/S2AProtocolNegotiatorFactoryTest.java
Show resolved
Hide resolved
larry-safran
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
kannanjgithub
pushed a commit
to kannanjgithub/grpc-java
that referenced
this pull request
Oct 23, 2024
* Add S2AStub cleanup handler. * Give TLS and Cleanup handlers name + update comment. * Don't add TLS handler twice. * Don't remove explicitly, since done by fireProtocolNegotiationEvent. * plumb S2AStub close to handshake end + add integration test. * close stub when TLS negotiation fails.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.