s2a: don't use reflection to load token manager. #11590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rmehta19
force-pushed
the
s2a-access-token
branch
from
b4b9978 to
e720d50
Compare
rmehta19
force-pushed
the
s2a-access-token
branch
from
e720d50 to
63d49f9
Compare
larry-safran
approved these changes
Oct 2, 2024
ejona86
approved these changes
Oct 2, 2024
| ) | ||
|
|
||
| java_library( | ||
| name = "single_token_fetcher", |
There was a problem hiding this comment.
Oh, I understand more of what was going on here, now. You were thinking people didn't have to depend on certain targets. In OSS, they must get all-or-nothing of a particular Java package, and they get everything per-project (aka artifact, aka jar. So grpc-java/s2a folder here).
SingleTokenFetcher has so very, very little code and no dependencies. So it doesn't make sense to split it out into a separate package+project/artifact.
ejona86
added
the
kokoro:run
|
The bazel build is failing for this PR. |
grpc-kokoro
removed
the
kokoro:run
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
kannanjgithub
pushed a commit
to kannanjgithub/grpc-java
that referenced
this pull request
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address: #11113 (comment)