Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump github.com/envoyproxy/go-control-plane to v0.13.4 #7974

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 30, 2024

Description

This updates github.com/envoyproxy/go-control-plane to v0.13.4 and import new github.com/envoyproxy/go-control-plane/envoy module

Related to envoyproxy/go-control-plane#1074

RELEASE NOTES: None

@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/[email protected] branch 4 times, most recently from 8fa3f25 to f45d96d Compare December 30, 2024 08:39
@mmorel-35 mmorel-35 marked this pull request as draft December 30, 2024 08:43
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (724f450) to head (0f3ba07).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7974      +/-   ##
==========================================
+ Coverage   82.05%   82.17%   +0.11%     
==========================================
  Files         381      381              
  Lines       38539    38539              
==========================================
+ Hits        31622    31668      +46     
+ Misses       5602     5562      -40     
+ Partials     1315     1309       -6     

see 26 files with indirect coverage changes

@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/[email protected] branch 2 times, most recently from ba95fb4 to a55b2ed Compare December 30, 2024 21:19
@mmorel-35 mmorel-35 marked this pull request as ready for review December 30, 2024 21:29
@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/[email protected] branch 5 times, most recently from 16b8025 to 12f1107 Compare December 30, 2024 21:47
@@ -1,6 +1,6 @@
module google.golang.org/grpc/cmd/protoc-gen-go-grpc

go 1.22
go 1.22.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got pushback from users when we specified a min Go minor version in our go.mod. It forced all users to bump their min versions to use the latest version of gRPC Go. So we decided to remove the minor version in #7831. Let me open an issue with go-control-plane to see if they are willing to drop the minor version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened Opened envoyproxy/go-control-plane#1077, let's see what they think.

@purnesh42H purnesh42H added the Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. label Jan 2, 2025
@arjan-bal arjan-bal added the Type: Dependencies Updating/adding/removing dependencies label Jan 3, 2025
@arjan-bal arjan-bal added this to the 1.70 Release milestone Jan 3, 2025
@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/[email protected] branch 3 times, most recently from b285016 to c9b5007 Compare January 7, 2025 09:04
@mmorel-35 mmorel-35 changed the title deps: bump github.com/envoyproxy/go-control-plane to v0.13.2 deps: bump github.com/envoyproxy/go-control-plane to v0.13.4 Jan 7, 2025
@mmorel-35 mmorel-35 marked this pull request as draft January 8, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants