-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump github.com/envoyproxy/go-control-plane to v0.13.4 #7974
base: master
Are you sure you want to change the base?
deps: bump github.com/envoyproxy/go-control-plane to v0.13.4 #7974
Conversation
8fa3f25
to
f45d96d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7974 +/- ##
==========================================
+ Coverage 82.05% 82.17% +0.11%
==========================================
Files 381 381
Lines 38539 38539
==========================================
+ Hits 31622 31668 +46
+ Misses 5602 5562 -40
+ Partials 1315 1309 -6 |
ba95fb4
to
a55b2ed
Compare
16b8025
to
12f1107
Compare
cmd/protoc-gen-go-grpc/go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module google.golang.org/grpc/cmd/protoc-gen-go-grpc | |||
|
|||
go 1.22 | |||
go 1.22.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We got pushback from users when we specified a min Go minor version in our go.mod. It forced all users to bump their min versions to use the latest version of gRPC Go. So we decided to remove the minor version in #7831. Let me open an issue with go-control-plane to see if they are willing to drop the minor version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened Opened envoyproxy/go-control-plane#1077, let's see what they think.
b285016
to
c9b5007
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
c9b5007
to
0f3ba07
Compare
Description
This updates
github.com/envoyproxy/go-control-plane
to v0.13.4 and import newgithub.com/envoyproxy/go-control-plane/envoy
moduleRelated to envoyproxy/go-control-plane#1074
RELEASE NOTES: None