*: Added End-to End Style Test Coverage for LRS Scenarios in xDS Client #7973
Conversation
…s to verify the order of server-side events.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7973 +/- ##
==========================================
+ Coverage 81.84% 82.20% +0.35%
==========================================
Files 377 381 +4
Lines 38120 38539 +419
==========================================
+ Hits 31201 31682 +481
+ Misses 5603 5551 -52
+ Partials 1316 1306 -10 |
| @@ -59,8 +59,10 @@ func init() { | |||
| grpc.EnableTracing = false | |||
| } | |||
|
|
|||
| type connCtxKey struct{} | |||
| type rpcCtxKey struct{} | |||
| type ( | |||
There was a problem hiding this comment.
are the stats_test changes? Please revert the file if unrelated
| v3discoverypb "github.com/envoyproxy/go-control-plane/envoy/service/discovery/v3" | ||
| ) | ||
|
|
||
| // Tests the case where the management server returns an error in the ADS |
There was a problem hiding this comment.
copy paste error: ADS Stream -> LRS Stream
| resourceRequestCh := make(chan []string, 1) | ||
| backoffCh := make(chan struct{}, 1) | ||
|
|
||
| // Context with timeout for the test. |
There was a problem hiding this comment.
no need of this comment. Code is self explainatory
| client := createXDSClientWithBackoff(t, bc, streamBackoff) | ||
|
|
||
| // Start watching a resource. | ||
| const listenerName = "listener" |
There was a problem hiding this comment.
Since we are writing tests for LRS stream which is used for load reporting, we don't need watchers here. What we need is for client to report load and verify if the server's channel received the LRS request.
Can you take a look at how tests are written and how the lrs server setup here https://github.com/grpc/grpc-go/blob/master/xds/internal/xdsclient/tests/loadreport_test.go ? This will give you some idea on how to go about it
There was a problem hiding this comment.
Okay, I had a feeling this was a mistake. Thanks, I'll get this fixed.
|
@RyanBlaney the tests you have written are for ADS stream which is sending discover requests. For this we need e2e tests for LRS stream which sends load requests to management server. Please write similar tests as here https://github.com/grpc/grpc-go/blob/master/xds/internal/xdsclient/tests/loadreport_test.go |
Addresses #7704
This pull request adds test coverage for Load Reporting Service (LRS) scenarios within the
xdsclientpackage. The tests address various cases, such as stream failures, backoff mechanisms, and resource request handling when streams are unavailable.Highlights:
Test Coverage:
Consistency:
Release Notes:
Request for Feedback
WatchListenerRefinements:WatchListenerimplementation to better support LRS.Test Isolation:
load-reporttest cases from broader listener tests to improve test readability and maintainability.Error Simulation: