Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple DBs in Rails >= 6.1 #930

Merged
merged 7 commits into from
Feb 6, 2024
+108 −33
Merged

Add support for multiple DBs in Rails >= 6.1 #930

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
85e43c8
Add support for multiple DBs in Rails >= 6.1
joshwestbrook Jan 29, 2024
0ee633a
changelog entry
joshwestbrook Jan 29, 2024
794017a
rubocop
joshwestbrook Jan 29, 2024
c443151
Return nil to represent 'all' databases
joshwestbrook Feb 6, 2024
de4c005
No core extensions
joshwestbrook Feb 6, 2024
d61065c
ActiveRecord check in for_each_database
joshwestbrook Feb 6, 2024
0f8e6a8
don't return too early now
joshwestbrook Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/parallel_tests/tasks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ def configured_databases
end

def for_each_database(&block)
return unless defined?(ActiveRecord)

# Use nil to represent all databases
block&.call(nil)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be after this to preserve original behavior ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gosh, nice catch 😄 0f8e6a8


Expand Down