Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove voyageai from anthropic drivers config #1277

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Oct 22, 2024

Describe your changes

Changed

  • BREAKING: AnthropicDriversConfig no longer bundles VoyageAiEmbeddingDriver.
    This default configuration has been a source of confusion for users.

Issue ticket number and link

https://discord.com/channels/1096466116672487547/1250191293439676526/1298130335711891476


📚 Documentation preview 📚: https://griptape--1277.org.readthedocs.build//1277/

@collindutter collindutter force-pushed the refactor/anthropic branch 2 times, most recently from ccc87fe to 637f71c Compare October 22, 2024 16:04
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

MIGRATION.md Outdated
@@ -21,7 +55,7 @@ def handler_fn_stream_text(event: CompletionChunkEvent) -> None:

EventListener(handler=handler_fn_stream, event_types=[CompletionChunkEvent])
EventListener(handler=handler_fn_stream_text, event_types=[CompletionChunkEvent])
```
````
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional 4th tick?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops nope, updated

@collindutter collindutter requested a review from cjkindel October 23, 2024 16:52
vector_store_driver=LocalVectorStoreDriver(
embedding_driver=VoyageAiEmbeddingDriver()
)
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add the agent line here, not really critical

@collindutter collindutter merged commit f6ab3ed into dev Oct 23, 2024
15 checks passed
@collindutter collindutter deleted the refactor/anthropic branch October 23, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants