Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various RestApiTool improvements #1239

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Oct 8, 2024

Describe your changes

Changed

  • BREAKING: RestApiTool now returns a JsonArtifact instead of a TextArtifact.
  • BREAKING: Removed RestApiTool.response_body.
  • BREAKING: Changed RestApiTool fields from str to dict/list:
    • RestApiTool.request_path_params_schema (list)
    • RestApiTool.request_query_params_schema (dict)
    • RestApiTool.request_body_schema (dict)

Fixed

  • RestApiTool failing with native tool calling due to schemas being in schema description.

Issue ticket number and link

Discord conversation.


📚 Documentation preview 📚: https://griptape--1239.org.readthedocs.build//1239/

@collindutter collindutter mentioned this pull request Oct 8, 2024
1 task
@collindutter collindutter force-pushed the feature/rest-json branch 3 times, most recently from 0ead9ea to 153db5b Compare October 8, 2024 23:43
@collindutter collindutter force-pushed the feature/callable-schema branch 3 times, most recently from 58fd5e6 to 471b7f8 Compare October 9, 2024 16:51
Base automatically changed from feature/callable-schema to dev October 9, 2024 17:03
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
griptape/tools/rest_api/tool.py 94.59% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@collindutter collindutter changed the base branch from dev to main December 10, 2024 18:57
@collindutter collindutter added the type:enhancement Improvements to existing features label Dec 19, 2024
@collindutter collindutter added this to the 2.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant