Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension to 1D meshes in the 2D space #76

Merged

Conversation

fdzgallen
Copy link
Contributor

This PR allows one to read a Gmesh where the cells have dim 1 and the points have dim 2.

Please, @ericneiva, review and accept whenever you have some time. Thanks!

 * bugfixed in _setup_point_dim

Co-authored-by: Eric Neiva <[email protected]>
@ericneiva ericneiva self-assigned this Mar 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 93.98%. Comparing base (9989338) to head (dd8487e).

Files Patch % Lines
src/GmshDiscreteModels.jl 68.75% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   94.96%   93.98%   -0.99%     
==========================================
  Files           2        2              
  Lines         556      565       +9     
==========================================
+ Hits          528      531       +3     
- Misses         28       34       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericneiva ericneiva merged commit b743753 into gridap:master Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants