Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print formatted exception for station watcher #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Print formatted exception for station watcher #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions openhtf/output/servers/station_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import re
import socket
import threading
import traceback
import time
import types
from typing import Optional, Union
Expand Down Expand Up @@ -181,10 +182,16 @@ def run(self):
'`dictionary changed size during iteration`.')
time.sleep(0.1)
else:
_LOG.exception('Error in station watcher: %s', error)
formatted_exception = traceback.format_exception(
type(error), error, error.__traceback__)
_LOG.error('Error in station watcher: \n',
Comment on lines +185 to +187
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider using f-strings for better readability

Suggested change
formatted_exception = traceback.format_exception(
type(error), error, error.__traceback__)
_LOG.error('Error in station watcher: \n',
formatted_exception = traceback.format_exception(
type(error), error, error.__traceback__)
_LOG.error(f'Error in station watcher: \n{''.join(formatted_exception)}')

"".join(formatted_exception))
time.sleep(1)
except Exception as error: # pylint: disable=broad-except
_LOG.exception('Error in station watcher: %s', error)
formatted_exception = traceback.format_exception(
type(error), error, error.__traceback__)
_LOG.error('Error in station watcher: \n',
"".join(formatted_exception))
time.sleep(1)

@functions.call_at_most_every(float(CONF.frontend_throttle_s))
Expand Down