gateware.usb.request.standard: pass max packet size to GetDescriptor handler #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handler Previously, enumeration would fail on a low-speed device as it would try to return a longer packet that allowed to GetDescriptor requests. This makes sure to pass the max packet size through to the handler to set the limit correctly.
miek
force-pushed
the
descriptor_handler_limit_packet_length
branch
from
c30f428 to
9e540ae
Compare
martinling
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, enumeration would fail on a low-speed device:
which translates to
EOVERFLOW 75 Value too large for defined data type.Looking on the scope, we found that the device was trying to return a longer packet than allowed for GetDescriptor requests:
This change makes sure to pass the max packet size through to the handler to set the limit correctly.