Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GX-Runner to set Correlation ID for Sentry Issues #611

Merged

Conversation

Shinnnyshinshin
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin commented Jan 7, 2025

  • PR to allow for the Runner to set Correlation ID for Sentry Issues without too much code duplication. That feature is enabled here - https://github.com/greatexpectationslabs/gx-runner/pull/286
  • Adds call to _set_sentry_tags() method in _handle_event which is shared by both Agent and Runner, but in the Agent, this is a no-op.

@Shinnnyshinshin Shinnnyshinshin self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (c8e67bc) to head (e12b33f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   86.53%   86.57%   +0.03%     
==========================================
  Files          25       25              
  Lines        1196     1199       +3     
==========================================
+ Hits         1035     1038       +3     
  Misses        161      161              
Flag Coverage Δ
3.10 71.39% <33.33%> (-0.10%) ⬇️
3.11 71.39% <33.33%> (-0.10%) ⬇️
3.9 71.26% <33.33%> (-0.10%) ⬇️
integration 72.06% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shinnnyshinshin Shinnnyshinshin enabled auto-merge (squash) January 8, 2025 20:08
@Shinnnyshinshin Shinnnyshinshin merged commit 20e2c89 into main Jan 8, 2025
15 checks passed
@Shinnnyshinshin Shinnnyshinshin deleted the m/zelda-1201/allow-runner-to-tag-with-correlation-id branch January 8, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants