fix sidebar for documentation and /api-v16
#4331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dimaMachina, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
dimaMachina
commented
Jan 21, 2025
| @@ -27,6 +28,7 @@ export default withNextra({ | |||
| }); | |||
| return config; | |||
| }, | |||
| redirects: async () => vercel.redirects, | |||
There was a problem hiding this comment.
to have same redirects locally
dimaMachina
commented
Jan 21, 2025
Comment on lines
+2
to
+4
| docs: { | ||
| type: 'page', | ||
| title: 'Documentation' |
There was a problem hiding this comment.
we need to group mdx pages under some folder and set type: page so we'll have proper sidebar
dimaMachina
commented
Jan 21, 2025
| @@ -4,7 +4,6 @@ module.exports = { | |||
| content: [ | |||
| './pages/**/*.{ts,tsx,mdx}', | |||
| './icons/**/*.{ts,tsx,mdx}', | |||
| './css/**/*.css', | |||
There was a problem hiding this comment.
you should not include *.css for tailwindcss
benjie
approved these changes
Jan 21, 2025
JoviDeCroock
approved these changes
Jan 21, 2025
dimaMachina
commented
Jan 21, 2025
| @@ -7,12 +7,12 @@ GraphQL.JS is the reference implementation to the [GraphQL Specification](https: | |||
| while closely following the Specification. | |||
|
|
|||
| You can build GraphQL servers, clients, and tools with this library, it's designed so you can choose which parts you use, for example, you can build your own parser | |||
| and use the execution/validation from the library. There also a lot of useful utilities for schema-diffing, working with arguments and [many more](./utilities.mdx). | |||
There was a problem hiding this comment.
this link is 404, so I removed it cc @JoviDeCroock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.