deferred fragments can be skipped if non-deferred

now that we do not have duplication
graphql · Jan 9, 2025 · ae933ea · ae933ea
1 parent 76c0e90
commit ae933ea
Showing 1 changed file with 9 additions and 14 deletions.
diff --git a/src/execution/collectFields.ts b/src/execution/collectFields.ts
@@ -222,21 +222,9 @@ function collectFieldsImpl(
       case Kind.FRAGMENT_SPREAD: {
         const fragName = selection.name.value;
 
-        const newDeferUsage = getDeferUsage(
-          variableValues,
-          fragmentVariableValues,
-          selection,
-          deferUsage,
-        );
-
         if (
-          !newDeferUsage &&
-          (visitedFragmentNames.has(fragName) ||
-            !shouldIncludeNode(
-              selection,
-              variableValues,
-              fragmentVariableValues,
-            ))
+          visitedFragmentNames.has(fragName) ||
+          !shouldIncludeNode(selection, variableValues, fragmentVariableValues)
         ) {
           continue;
         }
@@ -249,6 +237,13 @@ function collectFieldsImpl(
           continue;
         }
 
+        const newDeferUsage = getDeferUsage(
+          variableValues,
+          fragmentVariableValues,
+          selection,
+          deferUsage,
+        );
+
         const fragmentVariableSignatures = fragment.variableSignatures;
         let newFragmentVariableValues: VariableValues | undefined;
         if (fragmentVariableSignatures) {